However, I noticed one remaining problem with the code. Just like in 1.16, the
radius server terminates the username at the first whitespace. This is *very*
un-unix, and overall a bad idea. The radius server should *not* arbitrarily
terminate what the user has sent as their username. A username with whitespace
should return an error (as it will with the current radius server code if the
whitespace is left alone). Here's a patch to make the server behave itself:
--- src.orig/users.c Wed Oct 30 20:12:35 1996
+++ src/users.c Thu Dec 19 18:06:01 1996
@@ -97,15 +97,6 @@
mode = FIND_MODE_NAME;
- ptr=req_name;
- while (*ptr != '\0') {
- if (*ptr == ' ' || *ptr == '\t') {
- *ptr = '\0';
- } else {
- ptr++;
- }
- }
-
req_namelen=strlen(req_name);
if (req_namelen < 1) {
-- Scott Barker Linux Consultant scott@galileo.cuug.ab.ca http://www.cuug.ab.ca:8001/~barkers/ (under construction)[ I try to reply to all e-mail within 3 days. If you don't ] [ get a response by then, I probably didn't get your e-mail. ] [ Unsolicited commercial and junk e-mail will be proof-read for US$100 ]
"The cow is nothing but a machine which makes grass fit for us people to eat." - John McNulty